Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite FilterRow to tsx #2699

Merged
merged 2 commits into from
Nov 28, 2024
Merged

rewrite FilterRow to tsx #2699

merged 2 commits into from
Nov 28, 2024

Conversation

PavloButynets
Copy link
Contributor

Rewrote FilterRow to tsx

Sonar issues fixed:
'columns' is missing in props validation
'filter' is missing in props validation
'isSelection' is missing in props validation
'columns.map' is missing in props validation

@PavloButynets PavloButynets added good first issue Good for newcomers TypeScript Convert to TS sonarFix fix the sonar issues labels Nov 14, 2024
@PavloButynets PavloButynets linked an issue Nov 14, 2024 that may be closed by this pull request
@Mav-Ivan
Copy link
Contributor

Don`t forget to assign yourself to this PR
image

@PavloButynets PavloButynets self-assigned this Nov 15, 2024
@Mav-Ivan
Copy link
Contributor

Remove the log and ask teammates for review once again

@PavloButynets PavloButynets force-pushed the bugfix/2171/FilterRow-to-tsx branch from 00af75e to 85d51e9 Compare November 27, 2024 12:12
@Made1ra Made1ra self-requested a review November 28, 2024 19:06
@Made1ra Made1ra merged commit 506b5de into develop Nov 28, 2024
9 checks passed
@Made1ra Made1ra deleted the bugfix/2171/FilterRow-to-tsx branch November 28, 2024 20:29
Made1ra pushed a commit that referenced this pull request Nov 29, 2024
Rewrote FilterRow to tsx

Sonar issues fixed:
'columns' is missing in props validation
'filter' is missing in props validation
'isSelection' is missing in props validation
'columns.map' is missing in props validation
Made1ra pushed a commit that referenced this pull request Nov 29, 2024
Rewrote FilterRow to tsx

Sonar issues fixed:
'columns' is missing in props validation
'filter' is missing in props validation
'isSelection' is missing in props validation
'columns.map' is missing in props validation
Made1ra pushed a commit that referenced this pull request Nov 29, 2024
Rewrote FilterRow to tsx

Sonar issues fixed:
'columns' is missing in props validation
'filter' is missing in props validation
'isSelection' is missing in props validation
'columns.map' is missing in props validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers sonarFix fix the sonar issues TypeScript Convert to TS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(SP: 1) Rewrite FilterRow to tsx format and fix the sonar issues
4 participants