-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite FilterRow to tsx #2699
Merged
Merged
rewrite FilterRow to tsx #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavloButynets
added
good first issue
Good for newcomers
TypeScript
Convert to TS
sonarFix
fix the sonar issues
labels
Nov 14, 2024
PavloButynets
requested review from
dudchakk,
Renatavl,
Mav-Ivan,
Mike-Popovych and
luiqor
November 14, 2024 22:30
Remove the log and ask teammates for review once again |
ShadowOfTheSpace
approved these changes
Nov 26, 2024
PavloButynets
force-pushed
the
bugfix/2171/FilterRow-to-tsx
branch
from
November 27, 2024 12:12
00af75e
to
85d51e9
Compare
Quality Gate passedIssues Measures |
Mav-Ivan
approved these changes
Nov 27, 2024
Made1ra
approved these changes
Nov 28, 2024
Made1ra
pushed a commit
that referenced
this pull request
Nov 29, 2024
Rewrote FilterRow to tsx Sonar issues fixed: 'columns' is missing in props validation 'filter' is missing in props validation 'isSelection' is missing in props validation 'columns.map' is missing in props validation
Made1ra
pushed a commit
that referenced
this pull request
Nov 29, 2024
Rewrote FilterRow to tsx Sonar issues fixed: 'columns' is missing in props validation 'filter' is missing in props validation 'isSelection' is missing in props validation 'columns.map' is missing in props validation
Made1ra
pushed a commit
that referenced
this pull request
Nov 29, 2024
Rewrote FilterRow to tsx Sonar issues fixed: 'columns' is missing in props validation 'filter' is missing in props validation 'isSelection' is missing in props validation 'columns.map' is missing in props validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote FilterRow to tsx
Sonar issues fixed:
'columns' is missing in props validation
'filter' is missing in props validation
'isSelection' is missing in props validation
'columns.map' is missing in props validation